Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate docs example sandboxes to use Vite instead of CRA #11392

Closed
alessbell opened this issue Nov 28, 2023 · 6 comments
Closed

Migrate docs example sandboxes to use Vite instead of CRA #11392

alessbell opened this issue Nov 28, 2023 · 6 comments
Labels
📚 good-first-issue Issues that are suitable for first-time contributors. 📝 documentation

Comments

@alessbell
Copy link
Contributor

Issue Description

There are three codesandboxes that live in the docs-examples repo and are referenced in our docs.

We'd like to migrate them to use Vite instead of CRA, as we're updating our guidance in the getting started part of our guide, and have already updated our error reproduction sandbox.

If there are other codesandboxes that don't yet live in docs-examples, we should move those over and also update them to use Vite.

While the PR(s) for the sandboxes themselves will be against docs-examples, any updates to file names should be reflected in the file names referenced in our docs in the relevant pages.

Link to Reproduction

https://github.com/apollographql/docs-examples/tree/main/apollo-client/v3

Reproduction Steps

No response

@alessbell alessbell added 📚 good-first-issue Issues that are suitable for first-time contributors. 📝 documentation labels Nov 28, 2023
@alessbell
Copy link
Contributor Author

cc: @apollographql/docs I wanted to surface this CRA > Vite move with you as well. Feel free to share any thoughts here, and if there are no objections we'll carry on :)

@Meschreiber
Copy link
Contributor

Thanks for the heads-up @alessbell ! No concerns on my end.

@hmousavin
Copy link

To prevent rework: I made PR to make this done

@jerelmiller
Copy link
Member

Finished in apollographql/docs-examples#133

Copy link
Contributor

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📚 good-first-issue Issues that are suitable for first-time contributors. 📝 documentation
Projects
None yet
Development

No branches or pull requests

4 participants