-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix up type in 3.9 branch after merge #11362
Conversation
|
size-limit report 📦
|
I'm going to merge this already to un-block the 3.9 branch and other PRs, but if there are any post-merge review comments, I'd be happy to open a follow-up PR to address those :) |
@@ -11,7 +11,7 @@ import type { Resolvers } from "../../core/index.js"; | |||
import type { ApolloCache } from "../../cache/index.js"; | |||
|
|||
export interface MockedProviderProps<TSerializedCache = {}> { | |||
mocks?: ReadonlyArray<MockedResponse>; | |||
mocks?: ReadonlyArray<MockedResponse<any, any>>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, I was just running into issues in my useLoadableQuery
branch because of this. Thanks for fixing!
Doing this as a PR to check in CI if this fixes up all the type problems we got by merging
main
into3.9
.The problem seems to have been introduced by adding the
variableMatcher?: VariableMatcher<TVariables>;
property and also referencingTVariables
in theResultFunction
signature forresult
, both over in #11178.