Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce IDE-only tsconfig.json to check tests too. #11359

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Nov 10, 2023

This creates a new tsconfig.json in src that will be picked up by VSCode and apply the rules of the parent tsconfig.json to tests as well - without tooling that relies on the <root>/tsconfig.json (e.g. the build steps) having to pick up all the test files.

It should also fix the matcher inclusion problem (toRerender in expect(ProfiledHook).not.toRerender(); being unknown unless another editor window has the matches/index.d.ts open).

I'm opening this PR against the strict: true PR as that PR fixes a lot of problems we'd otherwise see in our tests.

Copy link

changeset-bot bot commented Nov 10, 2023

⚠️ No Changeset found

Latest commit: 04dcc0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@phryneas
Copy link
Member Author

phryneas commented Nov 10, 2023

Oh great, for some cursed reason this crashes our linter. fixed it.

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for looking into this!

Copy link
Contributor

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you for fixing this!

@jerelmiller jerelmiller merged commit 2cb5c83 into enable-strict-mode Nov 10, 2023
3 checks passed
@jerelmiller jerelmiller deleted the pr/enable-test-ts branch November 10, 2023 18:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants