-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7843 add context update #11339
7843 add context update #11339
Conversation
@Troyblants: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
Name | Link |
---|---|
🔨 Latest commit | 4ca6362 |
|
Related issue: #7843 Hi @Troyblants! I like the genereral "core" direction you are going here, (adding a third argument with Generally, we probably need to move away from generic declarations like this, as they are more akin to an I know, a lot of work has gone into adding those generics everywhere (and I'm really sorry to ask this of you 😞), but could you please do the PR without them? |
Hey @Troyblants 👋 Just wanted to check in and see if you're still interested in moving this PR forward! I know you've done a ton of work in this PR and just wanted to give a gentle nudge here. Thanks! |
Hey @Troyblants 👋 Due to lack of activity, I'm going to go ahead and close this PR. Feel free to reopen if you're interested in seeing this change through. Thanks again for the contribution! |
Checklist: