-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an explicit return type for useReadQuery
#11297
Conversation
🦋 Changeset detectedLatest commit: a7700c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -0,0 +1,5 @@ | |||
--- | |||
"@apollo/client": patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked this as a patch since this is a fully backwards compatible change. I'm happy to move this to a minor
and merge this into release-3.9
if that makes more sense.
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good idea, approved! :)
The
useReadQuery
hook currently uses type inference for the return type from the hook. For consistency, I added aUseReadQueryResult
type that can be used to get a typed return type rather than having to rely ontypeof useReadQuery
, which doesn't allow the use of the genericTData
type argument.Checklist: