Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated SuspenseCache export #11229

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

phryneas
Copy link
Member

Isn't it nice to have a PR that just removes code? :)

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023

🦋 Changeset detected

Latest commit: 32db9fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas phryneas changed the title Remove superfluous SuspenseCache export Remove deprecated SuspenseCache export Sep 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 37.1 KB (-0.49% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 43.44 KB (-0.71% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 41.99 KB (-0.8% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.52 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.27 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.21 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.2 KB (-0.09% 🔽)
import { useQuery } from "dist/react/index.js" 4.27 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.08 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.58 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.4 KB (0%)
import { useMutation } from "dist/react/index.js" 2.52 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.51 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.24 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.2 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 4.59 KB (-3.45% 🔽)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.02 KB (-4.04% 🔽)
import { useBackgroundQuery } from "dist/react/index.js" 4.1 KB (-4.2% 🔽)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.52 KB (-4.81% 🔽)
import { useReadQuery } from "dist/react/index.js" 2.96 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.91 KB (0%)
import { useFragment } from "dist/react/index.js" 2.08 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.03 KB (0%)

@phryneas phryneas requested a review from alessbell September 20, 2023 15:04
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🔥 gosh how did we forget about this in the 3.8 release?!?! Great to have removed code!

@phryneas phryneas merged commit c372bad into main Sep 20, 2023
8 checks passed
@phryneas phryneas deleted the pr/remove-suspensecache-export branch September 20, 2023 16:31
This was referenced Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants