Clean up subscriptions using requestIdleCallback instead of setTimeout

[raymondwang]

Checklist:

• If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
• If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests

Referenced in #11214.

[apollo-cla]

@raymondwang: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

[netlify]

‼️ Deploy request for apollo-client-docs rejected.

Name	Link
🔨 Latest commit	6cd5907

[changeset-bot]

🦋 Changeset detected

Latest commit: 6cd5907

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[jerelmiller]

Hey @raymondwang 👋

Since it looks like you're wanting to experiment with whether this change improves performance, I'll go ahead and create a snapshot release you can use to install this change. Let us know if it helps!

[jerelmiller]

/release:pr

[raymondwang]

I polyfilled this for compatibility with other environments (including Jest…), but exposing it via the public API for utilities seemed like overkill. Let me know if this feels like the wrong place and I'm happy to move things around.

[github-actions]

A new release has been made for this PR. You can install it with npm i @apollo/[email protected].

[raymondwang]

Thanks @jerelmiller! Just tested this solution against my environment with a couple thousand subscriptions and… this change seems to make things dramatically worse. Individual unsubscribe tasks look like they're going from 0.2 - 0.5 ms to around 1.5 - 2 ms — unacceptably slow. We're converting our query hooks to useFragment calls, but I'll keep digging on this later this week to see if I can better optimize this.

[jerelmiller]

Dang thats a bummer! Appreciate you taking the time to try some things out! Let me know if/when you have some changes you'd like to test against a snapshot release and I or one of the team would be happy to kick off the workflow again.

[jerelmiller]

Hey @raymondwang 👋

I'm doing a bit of a cleanup on open PRs and noticed there hasn't been much activity lately. I'm going to go ahead and close this PR. If you'd like to continue experimenting, feel free to reopen this PR and submit changes. At the very least, thanks for the exploration thus far!