Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo Devtools extension download message check if does not exist #11216

Conversation

alexandermirzoyan
Copy link

This PR is about having a working check before logging "Download the Apollo DevTools for a better development..." message.

@apollo-cla
Copy link

@alexandermirzoyan: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@netlify
Copy link

netlify bot commented Sep 14, 2023

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 45489b9

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

⚠️ No Changeset found

Latest commit: 45489b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@phryneas
Copy link
Member

Is this in itself still a problem for you with the latest version of Apollo Client? The check itself has recently been changed to not trigger false positives.

@alexandermirzoyan
Copy link
Author

I thought !(window as any).__APOLLO_DEVTOOLS_GLOBAL_HOOK__ this line was not working. Seems it's added after v3.7.0, as we use that version in our codebase.

@phryneas
Copy link
Member

The important part was added in 3.8.2 (I think) - a setTimeout before making the check, to give the devtools time to initialize before checking if they are there.
Please give the latest version a test - this might not be necessary anymore.

@alexandermirzoyan
Copy link
Author

Great! Thank you.
So I am going to close this PR

@phryneas
Copy link
Member

Thanks a ton for the PR though, I really appreciate the time you put into this :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants