Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Look into storybook-addon-apollo-client #11079

Open
phryneas opened this issue Jul 18, 2023 · 1 comment
Open

TODO: Look into storybook-addon-apollo-client #11079

phryneas opened this issue Jul 18, 2023 · 1 comment
Labels
🔍 investigate Investigate further

Comments

@phryneas
Copy link
Member

@alessbell noticed https://storybook.js.org/addons/storybook-addon-apollo-client .

We might look into it a bit, especially into their use of a globalMocks option, which seems a bit dangerous, as our MockProvider will usually mutate the mocks array passed into it.

There might be potential in suggesting that they use a custom link instead, which might serve them better.
@phryneas phryneas added the 🔍 investigate Investigate further label Jul 18, 2023
@alessbell
Copy link
Contributor

Also see related comment on testing RFC issue: #9738 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔍 investigate Investigate further
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phryneas @alessbell