Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document addTypePolicy #10933

Closed
phryneas opened this issue May 30, 2023 · 5 comments · Fixed by #10967
Closed

document addTypePolicy #10933

phryneas opened this issue May 30, 2023 · 5 comments · Fixed by #10967
Labels
📚 good-first-issue Issues that are suitable for first-time contributors. 📝 documentation 🙏 help-wanted ⚗️ needs-documentation

Comments

@phryneas
Copy link
Member

phryneas commented May 30, 2023 •
edited
Loading

Issue Description

It seems like we don't have addTypePolicy anywhere in the docs - we should definitely add that.

This came up here:

This came up here

https://stackoverflow.com/questions/76356769/apollo-client-is-there-a-way-to-define-apollo-client-type-policy-after-the-clie/76359617
@sahilmanchanda1999
Copy link
Contributor

Hi @phryneas,

I would like to contribute to this issue. I have implemented my suggestions in the document at this link (https://github.com/apollographql/apollo-client/blob/main/docs/source/caching/cache-configuration.mdx').

Please review the screenshot and let me know if you have any questions or feedback.

image

Thanks,
Sahil Manchanda

@jerelmiller
Copy link
Member

@sahilmanchanda1999 feel free to submit a PR! My at-a-glance read through of this looks good, but we can provide more detailed feedback in a pull request. Thanks for volunteering!

@sahilmanchanda1999
Copy link
Contributor

Hi @jerelmiller,

Thanks for the feedback. I have created a pull request for the same. #10967

Regards,
Sahil Manchanda

@jerelmiller jerelmiller linked a pull request Jun 12, 2023 that will close this issue
Added 'Customizing Type Policies' Segment in cache-configuration.mdx #10933 #10967
Merged
3 tasks
@sahilmanchanda1999
Copy link
Contributor

Hi @jerelmiller,

I apologize for the delay. I have made the requested updates based on your suggestion #10967 . If there are any further modifications needed, please let me know.

Regards,
Sahil Manchanda

phryneas added a commit that referenced this issue Sep 14, 2023
@sahilmanchanda1999 @jerelmiller @phryneas
Added 'Customizing Type Policies' Segment in cache-configuration.mdx #…
ae2651a 
…10933 (#10967)

Co-authored-by: Jerel Miller <[email protected]>
Co-authored-by: Lenz Weber-Tronic <[email protected]>
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
📚 good-first-issue Issues that are suitable for first-time contributors. 📝 documentation 🙏 help-wanted ⚗️ needs-documentation
Projects
None yet
Milestone
No milestone
3 participants
@jerelmiller @phryneas @sahilmanchanda1999