Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] React Router 7 integration #394

Draft
wants to merge 27 commits into
base: pr/multipart-streaming
Choose a base branch
from

Conversation

phryneas
Copy link
Member

No description provided.

Copy link

pkg-pr-new bot commented Nov 25, 2024

npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/client-react-streaming@394
npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/client-integration-react-router@394
npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/experimental-nextjs-app-support@394

commit: 93e20db

Copy link

relativeci bot commented Nov 25, 2024

#345 Bundle Size — 1.32MiB (+5.84%).

93e20db(current) vs 9d0a77a main#331(baseline)

Note

Bundle removed 1 duplicate package – View changed duplicate packages

Bundle metrics  Change 9 changes Regression 2 regressions Improvement 2 improvements
                 Current
#345
     Baseline
#331
Regression  Initial JS 1.04MiB(+4.24%) 1016.77KiB
No change  Initial CSS 70B 70B
Change  Cache Invalidation 85.18% 0.08%
Change  Chunks 36(+5.88%) 34
Change  Assets 62(+5.08%) 59
Change  Modules 678(+6.6%) 636
Regression  Duplicate Modules 119(+12.26%) 106
Change  Duplicate Code 5.35%(+14.81%) 4.66%
Improvement  Packages 25(-3.85%) 26
Improvement  Duplicate Packages 0(-100%) 1
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#345
     Baseline
#331
Regression  JS 1.31MiB (+5.81%) 1.24MiB
Regression  Other 10.01KiB (+10.12%) 9.09KiB
No change  CSS 70B 70B

Bundle analysis reportBranch pr/react-router-7Project dashboard


Generated by RelativeCIDocumentationReport issue

@@ -0,0 +1,106 @@
{
"name": "@apollo/client-integration-react-router",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig the name 👍

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 93e20db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@phryneas
Copy link
Member Author

Upgrading to React 19 solves the hydration problems and hanging stream I was seeing. Since we have that as a peerDependency anyways, that should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants