-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README links to point to non-experimental hooks links #309
Conversation
@jer-k: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-client-nextjs-docmodel pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Thanks so much for updating this.
@@ -5,8 +5,8 @@ | |||
# Apollo Client support for the Next.js App Router | |||
|
|||
> ❗️ This package is experimental.<br/> | |||
> Generally it should work well, you might run into race conditions when your Client Component is still rendering in SSR, and already making overlapping queries on the browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whitespace was unfortunately very important - in GitHub markdown, two spaces at a line end mark a <br/>
tag 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thats quite a choice by them. It looks like \
also works to add line breaks, would you be okay with a PR that uses those as the more explicit option to get the docs back to the way they were?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jer-k yes! Apologies on my part for not realizing the spaces were intentional. I've got a command to remove trailing whitespace when I save in my editor, so I think the more explicit \
would be welcome :).
Feel free to open a new PR if you'd like, otherwise I can tackle this later today.
Hi, I noticed that the links to
useSuspenseQuery
anduseFragment
weren't linking to the proper place. It looks like those hooks got moved out of experimental and are stable now. I updated those links. Looks like my editor also cleared out some trailing whitespace, hopefully that is okay.