add shared @apollo/experimental-nextjs-app-support entry point
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#198 Bundle Size — 1.07MiB (+6.53%).Warning Bundle contains 1 duplicate package – View duplicate packages Bundle metrics
|
| Current #198 |
Baseline #189 |
|
|---|---|---|
 Initial JS |
938.93KiB(+5.31%) |
891.55KiB |
| Initial CSS |
70B(+100%) |
0B |
 Cache Invalidation |
85.99% |
0.04% |
| Chunks |
32(+33.33%) |
24 |
| Assets |
56(+24.44%) |
45 |
| Modules |
591(+15.43%) |
512 |
| Duplicate Modules |
110(+266.67%) |
30 |
| Duplicate Code |
7.61%(+489.92%) |
1.29% |
 Packages |
26(-10.34%) |
29 |
 Duplicate Packages |
1 |
1 |
Bundle size by type 3 changes 3 regressions
| Current #198 |
Baseline #189 |
|
|---|---|---|
| JS |
1.06MiB (+6.3%) |
1MiB |
| Other |
8.67KiB (+44.68%) |
5.99KiB |
| CSS |
70B (+100%) |
0B |
Bundle analysis report Branch pr-unify-entrypoints Project dashboard
phryneas
changed the title
@apollo/experimental-nextjs-app-support entry point
phryneas
commented
May 15, 2024
Comment on lines
-112
to
-122
| typeof window === "undefined" | ||
| ? ApolloLink.from([ | ||
| // in a SSR environment, if you use multipart features like | ||
| // @defer, you need to decide how to handle these. | ||
| // This strips all interfaces with a `@defer` directive from your queries. | ||
| new SSRMultipartLink({ | ||
| stripDefer: true, | ||
| }), | ||
| httpLink, | ||
| ]) | ||
| : httpLink, |
There was a problem hiding this comment.
I believe this is something that's copied blindly without any real need, so I'll omit the complexity here for now.
jerelmiller
reviewed
May 15, 2024
jerelmiller
approved these changes
May 15, 2024
| export { | ||
| InMemoryCache as NextSSRInMemoryCache, | ||
| ApolloClient as NextSSRApolloClient, |
There was a problem hiding this comment.
Do we need a way to mark these as deprecated? Or is there another way we can hint that these exports will be removed in a future version?
There was a problem hiding this comment.
I was thinking about that, too.... I think I'll merge this as-is and add another PR for that.
Co-authored-by: Jerel Miller <[email protected]>
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies
@apollo/experimental-nextjs-app-support/rscand@apollo/experimental-nextjs-app-support/ssrinto@apollo/experimental-nextjs-app-support.Once we rename the package to remove the
experimentallabel, this will be the only entry point.Also, some imports are changed:
useQuery/useSuspenseQueryetc. hooks have been dropped. They should be imported from@apollo/clientinstead.NextSSRApolloClienthas been renamed toApolloClientand is available in different variations from all environments, including RSC.NextSSRInMemoryCachehas been renamed toInMemoryCacheand is available in different variations from all environments, including RSC.resetNextSSRApolloSingletonshas been renamed toresetApolloClientSingletons