0.10.0 (2) - Warn if makeClient returns the same client for multiple requests.

[phryneas]

No description provided.

[jerelmiller]

I assume that you haven't written tests because this is an [idea] right?

In general I like this idea a lot since it at least gives some indication of a potential footgun for those that are possibly unaware of the impact of returning the same client instance. Nice work!

[phryneas]

Yup, I wanted to make sure we actually want to do this before I get into the nitty-gritty of figuring out how to write a test against a RSC environment :)

[jerelmiller]

Had some small suggestions on wording, but this is great!

[relativeci]

Job #106: Bundle Size — 1.01MiB (0%).

c127d4f(current) vs e0b4862 main#104(baseline)

Warning

Bundle contains 1 duplicate package – View duplicate packages

Bundle metrics  no changes

	Current Job #106	Baseline Job #104
Initial JS	890.59KiB	890.59KiB
Initial CSS	0B	0B
Cache Invalidation	0.04%	0.04%
Chunks	24	24
Assets	45	45
Modules	512	512
Duplicate Modules	30	30
Duplicate Code	1.29%	1.29%
Packages	29	29
Duplicate Packages	1	1

Bundle size by type  no changes

	Current Job #106	Baseline Job #104
JS	1023.85KiB	1023.85KiB
Other	5.99KiB	5.99KiB

---

View job #106 report View pr/getClient-makeUniqueClients branch activity View project dashboard

[github-actions]

size-limit report 📦

Path	Size
{ ApolloNextAppProvider, NextSSRApolloClient, NextSSRInMemoryCache } from '@apollo/experimental-nextjs-app-support/ssr' (Browser ESM)	7.79 KB (0%)
{ WrapApolloProvider, ApolloClient, InMemoryCache } from '@apollo/client-react-streaming' (Browser ESM)	1.41 KB (0%)
{ buildManualDataTransport } from '@apollo/client-react-streaming/manual-transport' (Browser ESM)	6.27 KB (0%)
@apollo/client-react-streaming (Browser ESM)	2.14 KB (0%)
@apollo/client-react-streaming (SSR ESM)	1.74 KB (0%)
@apollo/client-react-streaming (RSC ESM)	1.33 KB (+18.68% 🔺)
@apollo/client-react-streaming/manual-transport (Browser ESM)	6.46 KB (0%)
@apollo/client-react-streaming/manual-transport (SSR ESM)	6.34 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (Browser ESM)	8.41 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (SSR ESM)	8.33 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (RSC ESM)	867 B (+1.17% 🔺)
@apollo/experimental-nextjs-app-support/rsc (RSC ESM)	626 B (+54.19% 🔺)