feat(*): add support for new architecture

[ThibaultBee]

Update to Fabric architecture and clean the project

[ThibaultBee]

Status: Waiting for test

What has been done?

• iOS: both old and new arch
• Android: both old and new arch
• Android: manage permissions at low level (bugfix in progress)
• Android preview: [Bug]: LiveStreamView Warp #64

Not tested but it should fixed

• [Bug]: Expo SDK 49 #66
• [Bug]: Build failure on new project #65

What is missing?

• tests Android legacy arch
• tests Android new arch
• tests iOS legacy arch
• tests iOS new arch

TODO

• Issue on orientation when changing device from portrait to landscape

How can I help?

• By testing the example with one or several of the following case: Android old arch, Android new arch, iOS old arch, iOS new arch.

How to test?

• Directly by using the example: See https://github.com/apivideo/api.video-reactnative-live-stream?tab=readme-ov-file#example-app
• In your project: install this branch with: yarn add https://github.com/apivideo/api.video-reactnative-live-stream.git#feature/new_arch_support

Please write you have been testing 🙏

[ThibaultBee]

@BlueBazze

Your issue happens here: https://github.com/ThibaultBee/StreamPack/blob/994b995705e1566ccb2a18d848ad907e4afaebdb/core/src/main/java/io/github/thibaultbee/streampack/internal/sources/AudioSource.kt#L63
I guess we should check that create returns a null object. But it is odd that isAvailable is true in this case. I will make the change but this will be released later.

I am currently releasing the Android dependency to integrate the fixes on the preview in this branch.

Are you going to perform other tests?
Not sure if you said it but have you tested on new arch or on old arch?

@Veryinheart @matthewfleming How long do you need to test this PR?

[BlueBazze]

Are you going to perform other tests?

Yes, i havent started actually streaming yet.

Not sure if you said it but have you tested on new arch or on old arch?

The very first one was with the old arch i believe.
But it should be the new one. I specified expo to use the new arch: https://github.com/BlueBazze/api.video-reactnative-live-stream-expo-demo/blob/master/app.json#L45-L50
But i dont know how it works under the hood and how it knows which arch to use from the package.

Is there a way to check which arch it is running on from the running code?

[ThibaultBee]

But i dont know how it works under the hood and how it knows which arch to use from the package.

This package is supposed to support both arch on iOS and Android.

Is there a way to check which arch it is running on from the running code?

Not sure... There might be a log somewhere.

[Veryinheart]

@BlueBazze

Your issue happens here: https://github.com/ThibaultBee/StreamPack/blob/994b995705e1566ccb2a18d848ad907e4afaebdb/core/src/main/java/io/github/thibaultbee/streampack/internal/sources/AudioSource.kt#L63 I guess we should check that create returns a null object. But it is odd that isAvailable is true in this case. I will make the change but this will be released later.

I am currently releasing the Android dependency to integrate the fixes on the preview in this branch.

Are you going to perform other tests? Not sure if you said it but have you tested on new arch or on old arch?

@Veryinheart @matthewfleming How long do you need to test this PR?

Hi @ThibaultBee , we have tested on some devices and below is the result:

IOS:
iPhone 14 Pro - iOS 16.2 works well
iPhone X - iOS 15.5 works well
iPhone 7 -iOS 14.7. works well

Android:
Samsung galaxy S9 - android 10 works well. Live streaming dropped once and restarted it and everything is ok, so might be the network issue.
Samsung galaxy S7 - works well
Pixel 6a - android 14- works well

Question: Do we support live stream in background mode? live stream will be stopped if we move app to background mode when it is live streaming.

[ThibaultBee]

Question: Do we support live stream in background mode? live stream will be stopped if we move app to background mode when it is live streaming.

Yes, this is on purpose. I thought using cameras in background was not legit for Android but I am not sure anymore. But we will have to use a backgroud service and it is not something we want to do.
Moreover, it is the same behavior as camera applications.

[BlueBazze]

I've tested streaming on Iphone 8 and Samsung A22, couldn't find any problems.
Havent tested orientation change, ill get to it as soon as possible.

[BlueBazze]

Yes, this is on purpose. I thought using cameras in background was not legit for Android but I am not sure anymore. But we will have to use a backgroud service and it is not something we want to do. Moreover, it is the same behavior as camera applications.

When i looked into this, the easiest way was to use PiP.
Back then i found this https://github.com/adkaushik/react-native-pip-android
But havent seen any other packages allowing this functionality, and i've thought of it as too big a hassle.
So if it creates another component specifically for the pip view, then react would render that as a seperate native component, and it would not contain the same data and state as the original stream view. Causing the pip view not to be live.
Otherwise the entire stream functionality would have to be packed into a singleton on the native side and each stream view would just be using the singleton information. Meaning only one stream could be active at any one point.

But yes. Older people (and even some younger) will not know why their stream stopped just because they tapped away from the application. What i have done is to display an in-app notification telling the user their stream has stopped, even if they stop streaming themselves..

[BlueBazze]

Orientation

Only tested on android.
The phone was rotated while the app was running before going live.

I restarted the app in landscape.

[ThibaultBee]

That's going to be a tricky one.

If you remove orientation in android:configChanges that might fix the issue.
On native Android application, the activity is recreated when the orientation of the device changes. This is not the case in RN application (not sure why).
But this is definitely something that should be handle by the library.

[BlueBazze]

If you remove orientation in android:configChanges that might fix the issue.

I dont believe it is present. With default expo the only app config available is https://docs.expo.dev/versions/latest/config/app/#orientation

Just to add on the orientation.
It works fine with the current master version as far as i know.

Listening to orientation change with an event listener and keep a state with the current orientation.
When pressing go live, lock the app orientation to the current.
When going offline you unlock the orientation.

This has worked great so far. But if the outgoing stream is not oriented according to the preview the user would not know until looking at the viewer perspective.

[ThibaultBee]

Your orientation setting is not the same as orientation in configChanges.
See

api.video-reactnative-live-stream/example/android/app/src/main/AndroidManifest.xml

Line 17 in aa6138b

android:configChanges="keyboard|keyboardHidden|orientation|screenSize|uiMode"

I need to dig a bit deeper in this issue.

[soemarko]

I need to dig a bit deeper in this issue.

I don't think this is an odd ask, but why not release this with the bug and continue working on the fix?

I don't think this bug has anything to do with this feature?

[ThibaultBee]

Mainly because this regression is due to the new architecture, so it is related to this branch.
Then, I think because of this regression, the lib is not usable. And the developer might not see the issue till it own application is in production.

And... the fix is going to be postponed because I am focusing on api.video project with a higher priority.

[ThibaultBee]

@BlueBazze
This issue was really a pain.
I just made a workaround for now. Could you give it a try?

[nikitapilgrim]

@ThibaultBee
for some reason the preview is black, sometimes when remount the component it appears. (iOS) legacy

[BlueBazze]

@BlueBazze
This issue was really a pain.
I just made a workaround for now. Could you give it a try?

Sorry, I kept forgetting about it.
I'll test first thing tomorrow morning.

[ThibaultBee]

@ThibaultBee for some reason the preview is black, sometimes when remount the component it appears. (iOS) legacy

@nikitapilgrim
I don't reproduce your issue. Are you using the provided example? How can I reproduced this behavior easily?

[BlueBazze]

Done testing on android. The previous issue has not occurred.
I believe that i tested the rotation on iOS last month. Ill test it again to make sure.

[BlueBazze]

Notice that,

Start streaming in portrait
Stop streaming
Rotate phone to landscape
Start streaming
After a few seconds it automatically throws onDisconnect

Log from the example app

 LOG  Streaming started
 LOG  Received onConnectionSuccess
 LOG  Received onDisconnect

This is because of my streaming streaming server not being able to handle a resolution change during the reconnection.
The reconnection window is about 1 minute.
Tried replicating this issue in OBS which also just kept retrying the connection.

The end user could accidentally start the stream in portrait, and then after seeing the preview change it to landscape.

The easiest solution would be to implement a timer when this scenario occurs.

I know this cant be fixed from the package. But down the line, it would be nice to see a reason argument for onDisconnect, that would describe how the stream was disconnected.

Was the disconnect userInitiated, connectionClosed etc..

[nikitapilgrim]

@ThibaultBee
#67 (comment)

I use react-native-vision-camera and this module in my project. When switching from react-native-vision-camera to this module, this bug occurs.
I was able to solve the problem by not displaying 'ApiVideoLiveStreamView' 500ms in timeout.

[ThibaultBee]

hmm looks like the camera has not been released when this package tries to access it. If this is the case, we can't really do something on our side.
Could you provide the logcat and/or a sample application to reproduce it?

[ThibaultBee]

@BlueBazze
Please open an issue for this. Do you see any returns except connection closed by remote ou connection closed by user

@nikitapilgrim
Could you also open an issue so we can track it?

I don't want to hold the release for these but we can work on it in a second time.