Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(junit-hamcrest): limit the scopes to test #61

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

sufyankhanrao
Copy link
Collaborator

@sufyankhanrao sufyankhanrao commented Sep 4, 2024

What

This PR limits the scope of the junit and hamcrest libraries so that the core library users don't run into version conflict issues for the testing suites.

Why

  • To avoid exposing the junit and hamcrest dependencies outside of the library
  • To avoid running into the version conflicts

Closes #60

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

This commit limits the scope of the junit and hamcrest libraries so that the core library users don't run into version conflict issues for the testing suites.

Closes #60
@sufyankhanrao sufyankhanrao added the dependency-update when a particular dependency gets updated in the library label Sep 4, 2024
@sufyankhanrao sufyankhanrao self-assigned this Sep 4, 2024
Copy link

sonarcloud bot commented Sep 4, 2024

@sufyankhanrao sufyankhanrao merged commit 6cd7e5d into main Sep 5, 2024
8 checks passed
@sufyankhanrao sufyankhanrao deleted the 60-limit-junit-hamcrest-lib-scopes branch September 5, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-update when a particular dependency gets updated in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the scope of the dependencies for JUnit and hamcrest to test
2 participants