Valid body doesn't get diff of added properties

[artem-zakharchenko]

Scenario

Whenever a body field is valid, even if an actual field has additional properties, those properties are not highlighted as added.

{
  "expected": { "login": "admin" },
  "actual": { "login": "joe", "newProp": true }
}

The newProp property won't be shown as the added one (green).

Expected behavior

Any property that is present in the actual HTTP message field (i.e. body, headers), but is not specified in the expected HTTP message field must be highlighted as the added one.

[artem-zakharchenko]

To clarify: if a body is invalid (i.e. there is a missing property in the actual body), then the new properties are highlighted as green. At first glance it looks like gavel2html skips the diff is a field is valid.

[artem-zakharchenko]

Here's the cause in the source code:

gavel2html/src/json-result-converter.coffee

Lines 185 to 188 in 99897d7

	#@private
	getErrorsFromResults: () ->
	if @fieldResult.errors.length == 0
	return [] # not sure about this, added keys will not be marked as added

Even the comment suggest there will be an issue, since the diff'ing is skipped when there are no errors.