Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why aren't hydra and openapi3 generating the same components #125

Open
aymaneabssi opened this issue Oct 20, 2022 · 1 comment
Open

Why aren't hydra and openapi3 generating the same components #125

aymaneabssi opened this issue Oct 20, 2022 · 1 comment

Comments

@aymaneabssi
Copy link

aymaneabssi commented Oct 20, 2022

Description
here I am testing the client generator and I am noticing that the hydra generates only this
`Interface for the "Book" resource type has been generated!

Interface for the "Review" resource type has been generated!

Interface for the "TopBook" resource type has been generated!`

and the openapi3 generate this:
`Interface for the "Book" resource type has been generated!;

Interface for the "Parchment" resource type has been generated!;

Interface for the "Review" resource type has been generated!;

Interface for the "TopBook" resource type has been generated!;
`

and when i looked at the endpoints on the api https://demo.api-platform.com/
i saw that there are 5
/books*
/parchments* // deprecated
/reviews*
/stats*
/top_books*

How to reproduce
I lunched the test-gen and test-gen-openapi3 commands

@alanpoulain
Copy link
Member

Deprecated resources are filtered by default:
https://github.com/api-platform/create-client/blob/d791b8e316916a3e9db8005d08d090fd04b00c4f/src/index.js#L123
However the api-doc-parser should be able to mark the Parchment resource as deprecated as well:

deprecated: !!pathItem.deprecated,

Transfering this issue to api-doc-parser. To investigate.

@alanpoulain alanpoulain transferred this issue from api-platform/create-client Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants