Updated DataIo Template (And working on the Siemens S7 L-types as well as Temporal types) #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Added support for 'BCD' formatted unsigned numbers in read- and write-buffer.
…n the new Profinet driver Also tried getting the old driver working with my Adam devices.
…working for S7-1500
… match the previous refactoring of the complex-types and enums.
… data-types working and all but the last two L-types for S7-1500
sruehl
requested changes
Feb 2, 2024
...n/language-java/src/main/java/org/apache/plc4x/language/java/JavaLanguageTemplateHelper.java
Outdated
Show resolved
Hide resolved
...n/language-java/src/main/java/org/apache/plc4x/language/java/JavaLanguageTemplateHelper.java
Outdated
Show resolved
Hide resolved
… the "all-types" test.
hutcheb
approved these changes
Feb 5, 2024
sruehl
reviewed
Feb 5, 2024
...ata/src/main/java/org/apache/plc4x/java/firmata/readwrite/protocol/FirmataProtocolLogic.java
Show resolved
Hide resolved
sruehl
reviewed
Feb 5, 2024
| @@ -71,12 +71,22 @@ public void onConnect(ConversationContext<FirmataMessage> context) { | |||
| LOGGER.debug("Sending Firmata Reset Command"); | |||
| FirmataMessageCommand resetCommandMessage = new FirmataMessageCommand(new FirmataCommandSystemReset()); | |||
| context.sendRequest(resetCommandMessage) | |||
| .onTimeout(e -> { | |||
| LOGGER.info("Timeout during Connection establishment, closing channel..."); | |||
There was a problem hiding this comment.
is the closing implicit or is there missing a close call here?
There was a problem hiding this comment.
Öhm ... from where I copied it from, it was commented out ;-)
There was a problem hiding this comment.
Maybe @splatch added that? :D. Anyway maybe it is better to name it channel will be closed as there is no immediate close call there.
There was a problem hiding this comment.
The onTimeout is not propagated well across stack, from what I remember in the past onTimeout had to specified at first, otherwise it was ignored/swallowed by lower part of engine. Not sure if that's true nowadays.
only combines those 2 and makes the code a bit more readable
sruehl
approved these changes
Feb 5, 2024
|
Ok ... pulled in all changes from develop ... time to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review especially the changes to generated DataIo types ... I know that at least in the Can driver I could see that now the encoding seems to be passed to the parser (which previously was not)
fixes #1379