fix: Fix a leak in PrefixAndTail operator. #1623
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fix @queimadus's report in #1566
Modification:
When the upstream finishes quickly but the downstream is not pulled, a leak can happen, so clean up that.
Result:
I think the leak should be fixed now
code from @queimadus
before:
after:
Seems there are more leak points.
I think the problem is the current logic design where arrays are been used to track and then with the current deign, there will be many many instances of the logic.
So That problem is harder to fix than we expected, but this pr is still valid.