spec: Add missing property in Snapshot #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuakeWang
reviewed
Aug 5, 2024
| /// Impl Reference: <https://github.com/apache/paimon/blob/release-0.8.2/paimon-core/src/main/java/org/apache/paimon/Snapshot.java#L506>. | ||
| #[derive(Debug, Clone, Copy, PartialEq, Eq, Deserialize, Serialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub enum CommitKind { |
There was a problem hiding this comment.
Hi @QuakeWang I think that just means log_offsets ?
Aitozi
commented
Aug 5, 2024
| @@ -39,6 +39,16 @@ pub struct Snapshot { | |||
| #[builder(default = None)] | |||
| index_manifest: Option<String>, | |||
| commit_user: String, | |||
| // Mainly for snapshot deduplication. | |||
| // | |||
| // If multiple snapshots have the same commitIdentifier, reading from any of these snapshots | |||
There was a problem hiding this comment.
I have a question out of this PR. Currently, the overwrite (expire partition) share the same commit identifier with the current snapshots's commit identifier. So I think this comments may not right ? CC @JingsongLi
|
It's my bad, when add the snapshot lost these field. Maybe I can add these in #39 with some tests. What do you think of this? |
|
@QuakeWang Sure, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fields in Snapshot are lost, add them back