S3 eu south #1950
Merged
S3 eu south #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added eu-south-1 (Milan) to the list of AWS regions.
Kami
reviewed
Sep 13, 2023
| @@ -1458,6 +1460,14 @@ class S3EUNorth1StorageDriver(S3StorageDriver): | |||
| ex_location_name = "eu-north-1" | |||
| region_name = "eu-north-1" | |||
|
|
|||
| class S3EUSouth1Connection(S3SignatureV4Connection): | |||
There was a problem hiding this comment.
There is no need anymore to define a class per region. A long time ago we moved away from a class per region to region constructor argument approach. Other classes were just left in places for backward compatibility reasons.
Just adding an entry to REGION_TO_HOST_MAP dictionary is sufficient.
Related comment on a similar PR - #1821 (comment).
libcloud/libcloud/storage/drivers/s3.py
Line 1253 in 9756484
asfgit
pushed a commit
that referenced
this pull request
Sep 13, 2023
|
I've removed unnecessary class for the connection and storage driver and merged change into trunk. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EU-South-1 (Milan) AWS region to s3 storage driver.
Description
EU-South was added similarly as EU-North.
I couldn't connect to EU-South region with K8ssandra's Medusa, which uses this storage driver to establish connection to AWS. After adding the region Medusa's connection worked.
Status
Checklist (tick everything that applies)