Whether stack trace is necessary, when GROUP share level is not used ？

[merrily01]

Under version 1.7，

When I start the beeline connection,

The stack trace always appears in the client log, as follows:

I found that it is because after the pr of #3897 is merged, When we create a new EngineRef, no matter which engine share level is used, getGroupNames will always be called.

Therefore, when the user does not use the GROUP mode, is it necessary to prompt the stack message above ？

[merrily01]

Kindly cc @pan3793

[pan3793]

Thanks for reporting, looks like it's fine to change the stack trace to debug, and just info "There is no group for , use the client user name as group directly." Would you like to send a PR to fix it?

More thought, caching the HadoopGroupProvider result or lazy evaluating the group name may be another optimization direction.

[merrily01]

Yeah, i will work on this.
Thanks for your suggestion :)

[pan3793]

link a previous discussion about GroupProvider in case you may be interested.
#4478

[merrily01]

Got it！ Thanks again

[yaooqinn]

let's fix this by moving sessionMgr.groupProvider inside EngineRef.appUser

   private[kyuubi] val appUser: String = shareLevel match {
     case SERVER => Utils.currentUser
-    case GROUP => primaryGroup
+    case GROUP => sessionMgr.groupProvider.primaryGroup(user, conf.getAll.asJava)
     case _ => user
   }

[merrily01]

Okay,

I was just thinking that this stack trace looks like a log converted after an internal call catches an exception, which is not easy to mask directly.

thank you for reminding.

[yaooqinn]

Would you mind to report this bug to the GitHub issue page for better issue-tracking

[merrily01]

Done, i have reported a issue: #4526 , and made a pr : #4527

[yaooqinn]

thank you

[merrily01]

FYI :

Releated issue : #4526

Solved by pr : #4527

[yaooqinn]

thank you @merrily01