Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async recover TsfileResource error handle #14234

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

HTHou
Copy link
Contributor

@HTHou HTHou commented Nov 28, 2024

Issue

image

How To Reproduce

  1. execute the following sql.
insert into root.sg.d1(time,s1) values(1,2)
flush
insert into root.sg.d1(time,s1) values(2,2)
flush
  1. stop iotdb datanode and delete the resource file of the first tsfile.
  2. restart datanode

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.62%. Comparing base (b34b714) to head (5a007e6).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../iotdb/db/storageengine/dataregion/DataRegion.java 50.00% 1 Missing ⚠️
...geengine/dataregion/utils/TsFileResourceUtils.java 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #14234   +/-   ##
=========================================
  Coverage     39.62%   39.62%           
  Complexity       71       71           
=========================================
  Files          4242     4242           
  Lines        270437   270459   +22     
  Branches      32792    32799    +7     
=========================================
+ Hits         107165   107174    +9     
- Misses       163272   163285   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 28, 2024

@JackieTien97 JackieTien97 merged commit 196795d into master Nov 29, 2024
34 checks passed
@JackieTien97 JackieTien97 deleted the fix_async_recover_error branch November 29, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants