Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWF-Editor: Dark theme support #1666

Open
Tracked by #1127
handreyrc opened this issue Dec 3, 2024 · 0 comments
Open
Tracked by #1127

SWF-Editor: Dark theme support #1666

handreyrc opened this issue Dec 3, 2024 · 0 comments
Assignees
Labels
area:sonataflow Related to CNCF Serverless Workflow Spec and SonataFlow area:tools Issues affecting Apache KIE tooling projects

Comments

@handreyrc
Copy link

handreyrc commented Dec 3, 2024

Summary

The goal of this task is to add theme support to the editor.
Initialy the editor shall support light and dark themes.

Note: The API to set theme shall work the same way as it works in the current implementation of the editor otherwise it won't be compatible with VsCode plugin and the combined editor. Follow the same color patterns of the current dark theme implementation.

Description

  • Implement and expose an API to set themes (applyTheme()).
  • Create a centralized theme configuration.
  • Add theme configuration support in the inialization of the editor.
  • The theme should be applied to all internal canvas elements.
  • If no theme is set in the initialization, the light theme shall be set by default.
  • Themes shall be also applied to the error page.

Testing

Run the component and open a valid worflow.
Open the console and call the API to set a theme theme, "applyTheme([light / dark])", and check if the theme was properly applied to all internal canvas elements.

Dependencies

@handreyrc handreyrc added area:tools Issues affecting Apache KIE tooling projects area:sonataflow Related to CNCF Serverless Workflow Spec and SonataFlow labels Dec 3, 2024
@handreyrc handreyrc self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sonataflow Related to CNCF Serverless Workflow Spec and SonataFlow area:tools Issues affecting Apache KIE tooling projects
Projects
None yet
Development

No branches or pull requests

1 participant