Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing migration script to register.go #8178

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

sstojak1
Copy link
Contributor

@sstojak1 sstojak1 commented Oct 31, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
Adds increaseProjectKeyLength and changeIssueComponentType to register.go

Does this close any open issues?

Closes #8177

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 31, 2024
klesh
klesh previously approved these changes Nov 1, 2024
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for your contribution.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 1, 2024
@sstojak1
Copy link
Contributor Author

sstojak1 commented Nov 4, 2024

@klesh can we merge it?

@klesh
Copy link
Contributor

klesh commented Nov 5, 2024

@sstojak1 Could you fix the test cases?

@sstojak1
Copy link
Contributor Author

sstojak1 commented Nov 5, 2024

@klesh, 20240813_change_issue_component_type is fixed. Could you run the tests again?

Before that, could you review the 20240813_increase_project_key_length script? It might fail since the project_key column doesn’t exist in cq_projects. Did you intend to modify a different column?

@klesh
Copy link
Contributor

klesh commented Nov 6, 2024

@sstojak1 I just checked the code and found out 20240813_increase_project_key_length under the core/model should be changing the length of cq_projects.id from 255 to 500 instead.
Would you kindly update the script to do so? Thanks, 🌹

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 8, 2024
@sstojak1
Copy link
Contributor Author

sstojak1 commented Nov 8, 2024

@klesh updated...

@klesh
Copy link
Contributor

klesh commented Nov 8, 2024

@sstojak1 Thank you very much for correcting my mistakes 🌹
I wondered why people kept reporting "Data too long" after my PR merged.

@sstojak1
Copy link
Contributor Author

sstojak1 commented Nov 8, 2024

I was almost one of them until I did a bit of troubleshooting 😅

Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit 7d3a792 into apache:main Nov 8, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Jira] Migration script not added to register.go
2 participants