-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing migration script to register.go #8178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks for your contribution.
@klesh can we merge it? |
@sstojak1 Could you fix the test cases? |
@klesh, 20240813_change_issue_component_type is fixed. Could you run the tests again? Before that, could you review the 20240813_increase_project_key_length script? It might fail since the project_key column doesn’t exist in cq_projects. Did you intend to modify a different column? |
@sstojak1 I just checked the code and found out |
@klesh updated... |
@sstojak1 Thank you very much for correcting my mistakes 🌹 |
I was almost one of them until I did a bit of troubleshooting 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pr-type/bug-fix
,pr-type/feature-development
, etc.Summary
What does this PR do?
Adds increaseProjectKeyLength and changeIssueComponentType to register.go
Does this close any open issues?
Closes #8177
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.