Webhook startedDate field ignored

[Mandla-SM]

Greetings DevLake team,

Webhook startedDate is ignored and the deploymentCommits.startedDate date of the last commit is used instead. This has the effect that a deployment then shows as if it happened on the day of the latest commit in that deployment. I'm wondering if this is deliberate.

example:
{
"id": "",
"startedDate": "2024-02-06T19:00:00+02:00",
"finishedDate": "2024-02-06T22:00:00+02:00",
"result": "Successful",
"deploymentCommits": [
{
"repoUrl": "",
"refName": "",
"startedDate": "2024-01-16T09:20:50+02:00",
"finishedDate": "2024-01-16T09:20:50+02:00",
...

Instead of 2024-02-06T19:00:00+02:00, 2024-01-16T09:20:50+02:00 is used as the deployment date. This shows up in Grafana.

Thank you for the fantastic tool!

Regards

[dosubot[bot]]

Hey @Mandla-SM! I'm here to help with any bugs, questions, or feedback you have. Let's work together to tackle this issue!

The behavior you're observing, where deploymentCommits.startedDate is used instead of startedDate, seems to be part of the logic for processing deployment data. The deploymentCommits.startedDate is crucial for tracking the start time of each commit's deployment, which is necessary for accurate DORA metrics calculation ^[1][2].

If the startedDate of the deployment is being ignored in favor of the last commit's startedDate, it might be due to how the deployment processing logic is designed to prioritize commit-specific timestamps. This ensures that the deployment timeline reflects the actual commit activities.

If this behavior is not what you expect, it might be worth reviewing the logic to see if adjustments are needed to align with your intended use case.

To continue talking to Dosu, mention @dosu.

[Mandla-SM]

@dosu, I disagreed. If a deployment is scheduled for a specific date and it happens and is successful, surely that is the actual deployment time. The last commit is simply part of what has been deployed like all the other commits.

[dosubot[bot]]

The issue you're describing makes sense. The startedDate of the deployment should indeed reflect the actual deployment time, not the time of the last commit. If the system is prioritizing deploymentCommits.startedDate over the deployment's startedDate, it might be worth reviewing the logic to ensure it aligns with your expectations.

If this behavior is not intended, you might consider checking the code handling the deployment date logic to see if adjustments are needed. This could involve ensuring that the deployment's startedDate is used as the primary reference for the deployment timeline.

To continue talking to Dosu, mention @dosu.