Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6086] fix(CLI): Refactor the validation logic of Metalake #6091

Merged
merged 15 commits into from
Jan 5, 2025
Merged

[#6086] fix(CLI): Refactor the validation logic of Metalake #6091

merged 15 commits into from
Jan 5, 2025

Conversation

Abyss-lord
Copy link
Contributor

@Abyss-lord Abyss-lord commented Jan 3, 2025 •
edited
Loading

What changes were proposed in this pull request?

Add validate method to Command, and refactor the validation code.

Why are the changes needed?

Fix: #6086

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT

local ut

bash

gcli metalake set
# Missing --metalake option.

gcli metalake details
# Missing --metalake option.

gcli metalake set -m demo_metalake
# Missing --property and --value options.

gcli metalake set -m demo_metalake --property propertyA
# Missing --value option.

gcli metalake set -m demo_metalake --value valA
# Missing --property option.

gcli metalake details --audit
# Missing --metalake option.

gcli metalake remove -m demo_metalake
# Missing --property option.

gcli metalake update -m demo_metalake
# The command does nothing.

@Abyss-lord
Copy link
Contributor Author

Hi @justinmclean @tengqm , could you please review this PR when you have time? I’d really appreciate your feedback.

tengqm
tengqm reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is on the right track, I believe.
Thanks.

clients/cli/src/main/java/org/apache/gravitino/cli/commands/Command.java Outdated Show resolved Hide resolved
jerqi and others added 11 commits January 4, 2025 13:39
@jerqi @Abyss-lord
[apache#6060] fix(core): Add the check of requests related to authori…
2bb614e 
…zation (apache#6065)

### What changes were proposed in this pull request?

Add the check of requests related to authorization

### Why are the changes needed?

Fix: apache#6060 
### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?
Added UT.
@jerqi @Abyss-lord
[apache#6061] fix(core): Fix the issues of list user or group details (…
9513baf 
…apache#6067)

### What changes were proposed in this pull request?

Fix the issues of list user or group details

### Why are the changes needed?

Fix: apache#6061

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?
Added UT.
@diqiu50 @Abyss-lord
[apache#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementa…
f282dce 
…tion and code structure layout (apache#5835)

### What changes were proposed in this pull request?

1. Implement basic FUSE interfaces.
2. Implement filesystem trait and relation structures.


### Why are the changes needed?

Fix: apache#5734

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No
@diqiu50 @Abyss-lord
[apache#5877] feat (gvfs-fuse): Implement a common filesystem layer (a…
433d9b9 
…pache#5878)

### What changes were proposed in this pull request?

Implement a common filesystem layer to handle manage file ids, file name
mappings, and file relationships. and delegate filesystem APIs to
PathFilesystem.

### Why are the changes needed?

Fix: apache#5877

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Uts
@diqiu50 @Abyss-lord
[apache#5886] feat (gvfs-fuse): Implement an in-memory file system (a…
22d59da 
…pache#5915)

### What changes were proposed in this pull request?

Implement an in-memory filesystem for testing and validating the FUSE
framework. You need to implement the PathFilesystem trait and support
basic file and directory operations:

### Why are the changes needed?

Fix: apache#5886

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

IT
@diqiu50 @Abyss-lord
[apache#5982] feat (gvfs-fuse): Implement Gravitino fileset file syst…
42171d4 
…em (apache#5984)

### What changes were proposed in this pull request?

Implement an Gravitino fileset file system, Support mount fileset to
local directory

### Why are the changes needed?

Fix: apache#5982

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

UT and IT
@diqiu50 @tengqm @Abyss-lord
[apache#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesyst…
4bf6e67 
…em operation in gvfs fuse (apache#6013)

### What changes were proposed in this pull request?

Support a Gravitino S3 fileset filesystem operation in gvfs fuse,
implemented by OpenDal

### Why are the changes needed?

Fix: apache#6012 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Manually test

---------

Co-authored-by: Qiming Teng <[email protected]>
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for mod…
d27dda0 
…el (apache#6066)

Add register and link commands to CLI for model
- register a model：`model create`
- link a model：`model update <—uri uri> [--alias aliaA aliaB]`

meantime, add two options
- `—uri` ：The URI of the model version artifact.
- `—alias` ：The aliases of the model version.

The documentation will be updated after apache#6047 merge and I will create a
new issue.

Fix: apache#5960

NO

```bash
gcli model create -m demo_metalake --name Hive_catalog.default.model
gcli model create -m demo_metalake --name Hive_catalog.default.model --comment comment
gcli model create -m demo_metalake --name Hive_catalog.default.model --properties key1=val1 key2=val2
gcli model create -m demo_metalake --name Hive_catalog.default.model --properties key1=val1 klinkey2=val2 --comment comment
```

```bash
gcli model update -m demo_metalake --name Hive_catalog.default.model --uri file:///tmp/file
gcli model update -m demo_metalake --name Hive_catalog.default.model --uri file:///tmp/file  --alias aliasA aliasB
gcli model update -m demo_metalake --name Hive_catalog.default.model --uri file:///tmp/file  --alias aliasA aliasB --comment comment --properties key1=val1 key2=val2
gcli model update -m demo_metalake --name Hive_catalog.default.model
```
@Abyss-lord
[apache#6086] fix(CLI): Refactor the validation logic of Metalake
387f5c5 
Add verify method to Command, and refactor the validation code.
@Abyss-lord
[apache#6086] fix(CLI): Refactor the validation logic of Metalake
29ff9b7 
fix some error.
@Abyss-lord
Merge branch 'main' into refactor-metalake-validation
daee832
@Abyss-lord
Copy link
Contributor Author

@justinmclean , I’ve finished updating the code. Please take a look at the PR again when you have time.

@Abyss-lord
Copy link
Contributor Author

@justinmclean I’ve finished updating the code. Please take a look at the PR again when you have time.

justinmclean
justinmclean approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@justinmclean justinmclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution.

@justinmclean justinmclean merged commit c16f595 into apache:main Jan 5, 2025
27 checks passed
@Abyss-lord Abyss-lord deleted the refactor-metalake-validation branch January 6, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@justinmclean justinmclean justinmclean approved these changes

Assignees

@Abyss-lord Abyss-lord

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Subtask] Refactor the validation logic of Metalake
5 participants
@Abyss-lord @justinmclean @tengqm @jerqi @diqiu50