Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum supported Rust version (MSRV) to 1.80.1 #13667

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Dec 5, 2024

Which issue does this PR close?

Rationale for this change

We currently require 1.80, but we also say that

If a hotfix is released for the minimum supported Rust version (MSRV),
the MSRV will be the minor version with all hotfixes

therefore we should requite 1.80.1 and thus allow dependencies that
require 1.80.1 (such as substrait)

What changes are included in this PR?

  • require 1.80.1 msrv

Are these changes tested?

existing tests

Are there any user-facing changes?

1.80.0 is no longer supported

relates to

@findepi findepi changed the title Findepi/msrv Increase minimum supported Rust version (MSRV) to 1.80.1 Dec 5, 2024
We currently require 1.80, but we also say that

> If a hotfix is released for the minimum supported Rust version (MSRV),
> the MSRV will be the minor version with all hotfixes

therefore we should requite 1.80.1 and thus allow dependencies that
require 1.80.1 (such as substrait)
@github-actions github-actions bot added development-process Related to development process of DataFusion core Core DataFusion crate proto Related to proto crate labels Dec 5, 2024
@findepi findepi requested review from alamb and jonahgao December 5, 2024 15:45
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi 👍. We should use version 1.80.1, which includes bug fixes.
Do we also need to update the Dockerfile?

@comphead
Copy link
Contributor

comphead commented Dec 5, 2024

Thanks @findepi
I should probably have made a policy slightly more clear to mention the hotfix related to rust compiler.

#13668

@findepi
Copy link
Member Author

findepi commented Dec 5, 2024

Do we also need to update the Dockerfile?

rust:1.80-bookworm ships rustc 1.80.1

@comphead comphead merged commit 2464703 into apache:main Dec 5, 2024
27 checks passed
@findepi findepi deleted the findepi/msrv branch December 5, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate development-process Related to development process of DataFusion proto Related to proto crate substrait
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants