Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ConfigOptions to ScalarFunctionArgs #13527

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Omega359
Copy link
Contributor

Which issue does this PR close?

Closes #13519

Rationale for this change

Allow udf's to access df config

What changes are included in this PR?

Code.

Are these changes tested?

Existing tests.

Are there any user-facing changes?

Not specifically, this is covered with the udf signature change in #13290

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Physical Expressions optimizer Optimizer rules core Core DataFusion crate common Related to common crate proto Related to proto crate functions labels Nov 22, 2024
@Omega359 Omega359 changed the title Feature/scalar func args session config feat: Add ConfigOptions to ScalarFuntionArgs Nov 22, 2024
@Omega359 Omega359 changed the title feat: Add ConfigOptions to ScalarFuntionArgs feat: Add ConfigOptions to ScalarFunctionArgs Nov 22, 2024
@Omega359
Copy link
Contributor Author

There is a lot of file changes here but most of the important changes are in scalar_function.rs, There is a todo in expr_simplifier.rs that I would like feedback on.

@Omega359 Omega359 marked this pull request as ready for review November 22, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Related to common crate core Core DataFusion crate functions logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions proto Related to proto crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SessionConfig reference to ScalarFunctionArgs
1 participant