Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subquery check_internal_plan does not support LogicalPlan::Unnest #13498

Open
kosiew opened this issue Nov 20, 2024 · 3 comments · May be fixed by #13523
Open

Subquery check_internal_plan does not support LogicalPlan::Unnest #13498

kosiew opened this issue Nov 20, 2024 · 3 comments · May be fixed by #13523
Labels
bug Something isn't working

Comments

@kosiew
Copy link

kosiew commented Nov 20, 2024

Describe the bug

The Error during planning: Unsupported operator in the subquery plan. error in
apache/datafusion-python#850 is due to
datafusion/optimizer/src/analyzer/subquery.rs's check_internal_plan not handling LogicalPlan::Unnest

To Reproduce

Follow the steps in apache/datafusion-python#850

Expected behavior

Datafusion should handle it

Additional context

No response

@kosiew kosiew added the bug Something isn't working label Nov 20, 2024
@kosiew
Copy link
Author

kosiew commented Nov 20, 2024

I can try to fix this but I don't know where the existing tests for check_inner_plan are.

@alamb
Copy link
Contributor

alamb commented Nov 20, 2024

@kosiew I would recommend trying to write a SQL query (or rust dataframe example) that shows the same behavior

the sql tests are in https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/unnest.slt

The dataframe test are in: https://github.com/apache/datafusion/blob/main/datafusion/core/tests/dataframe/mod.rs

@kosiew kosiew linked a pull request Nov 22, 2024 that will close this issue
@kosiew
Copy link
Author

kosiew commented Nov 22, 2024

Thanks @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants