chore: Add criterion benchmarks for casting between integer types #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
May 9, 2024
comphead
reviewed
May 9, 2024
| }); | ||
| } | ||
|
|
||
| fn create_int32_batch() -> RecordBatch { |
There was a problem hiding this comment.
just wondering should we have same for all ints/uint types?
There was a problem hiding this comment.
They should all be pretty similar, but we can modify the test as needed depending on what we need to benchmark at the time.
Co-authored-by: comphead <[email protected]>
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
…ache#401) * Add cargo bench for casting between int types * Update core/benches/cast_from_string.rs Co-authored-by: comphead <[email protected]> --------- Co-authored-by: comphead <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
We need benchmarks so that we can evaluate performance impacts of PRs that refactor existing code.
What changes are included in this PR?
New benchmark and some refactoring for code readability
How are these changes tested?