feat: Remove use of nightly int_roundings feature #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=========================================
Coverage 33.32% 33.32%
Complexity 769 769
=========================================
Files 107 107
Lines 37037 37037
Branches 8106 8106
=========================================
Hits 12342 12342
Misses 22098 22098
Partials 2597 2597 ☔ View full report in Codecov by Sentry. |
viirya
approved these changes
Mar 24, 2024
|
Merged, thanks! |
wangyum
pushed a commit
to wangyum/datafusion-comet
that referenced
this pull request
Mar 28, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partially implements #142 .
Rationale for this change
Int_roundings is not stabalized yet, so I am using the functions provided by num crate. This should help us a bit in migrating to stable rust.
What changes are included in this PR?
How are these changes tested?
Checked that the github ci passes in my forked repo.