Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comet query with range frame will fail #720

Closed
viirya opened this issue Jul 24, 2024 · 0 comments · Fixed by #719
Closed

Comet query with range frame will fail #720

viirya opened this issue Jul 24, 2024 · 0 comments · Fixed by #719
Labels
bug Something isn't working

Comments

@viirya
Copy link
Member

viirya commented Jul 24, 2024

Describe the bug

I found this issue while fixing CI failures in #651.

The following errors happens many times:

[info]   java.lang.ClassCastException: class java.lang.Long cannot be cast to class java.lang.Integer (java.lang.Long and java.lang.Integer are in module java.base of loader 'bootstrap')
[info]   at scala.runtime.BoxesRunTime.unboxToInt(BoxesRunTime.java:103)
[info]   at org.apache.comet.serde.QueryPlanSerde$.windowExprToProto(QueryPlanSerde.scala:281)

It is because we don't separate RangeFrame and RowFrame for window expression support. Looks like we only support RowFrame which can take integers as upper and lower bounds. So the current code just tries to cast upper and lower bound expression values into Int.

For RangeFrame, it can accept more data types. Once we do the casting there, it causes the errors.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant