Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported window expression now fails Comet query #711

Closed
viirya opened this issue Jul 24, 2024 · 0 comments · Fixed by #710
Closed

Unsupported window expression now fails Comet query #711

viirya opened this issue Jul 24, 2024 · 0 comments · Fixed by #710
Labels
bug Something isn't working

Comments

@viirya
Copy link
Member

viirya commented Jul 24, 2024

Describe the bug

I found this issue when fixing CI failure in #651.

Currently we wrongly ignore window expressions if its direct child expression is not a WindowExpression. It causes the following simple Spark query fail to run in Comet:

spark.sql("select sum(a) over () from values 1.0, 2.0, 3.0 T(a)")

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Unsupported window expression should fall back to Spark viirya/arrow-datafusion-comet
1 participant
@viirya