Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Scalar and Inverval values for UnaryMinus #508

Closed
kazuyukitanimura opened this issue Jun 3, 2024 · 3 comments · Fixed by #538
Closed

Add tests for Scalar and Inverval values for UnaryMinus #508

kazuyukitanimura opened this issue Jun 3, 2024 · 3 comments · Fixed by #538
Assignees
@vaibhawvipul
Labels
bug Something isn't working

Comments

@kazuyukitanimura
Copy link
Contributor

Describe the bug

Related to #471, we should add tests for Scalar and Inverval values for UnaryMinus

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response
@kazuyukitanimura kazuyukitanimura added the bug Something isn't working label Jun 3, 2024
@vaibhawvipul
Copy link
Contributor

I will work on this.

@kazuyukitanimura
Copy link
Contributor Author

Thank you @vaibhawvipul assigned this to you

@vaibhawvipul vaibhawvipul mentioned this issue Jun 7, 2024
Merged
@vaibhawvipul
Copy link
Contributor

@kazuyukitanimura I have added scalar tests, and I have also verified that it hits scalar path in the negative.rs code. Please review when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaibhawvipul vaibhawvipul

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add tests for Scalar and Inverval values for UnaryMinus vaibhawvipul/datafusion-comet
2 participants
@kazuyukitanimura @vaibhawvipul