Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for casting between timestamp types #467

Open
andygrove opened this issue May 23, 2024 · 1 comment
Open

Add tests for casting between timestamp types #467

andygrove opened this issue May 23, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

We currently delegate to DataFusion when casting between timestamps (as discovered in #461) but I am not convinced that we have comprehensive tests to ensure that this is compatible with Spark.

This issue is for adding specific tests for casting between timestamp types.

Describe the potential solution

No response

Additional context

No response

@parthchandra
Copy link
Contributor

In CometExpressionSuite we have -
test("cast timestamp and timestamp_ntz") (long -> timestamp/timestamp_ntz)
test("cast timestamp and timestamp_ntz to string")
test("cast timestamp and timestamp_ntz to long, date")

Do we want to add more values in these tests or do we want some more combinations tested (which ones)?

@andygrove andygrove added the help wanted Extra attention is needed label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants