Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate expression with filter is incorrectly translated to Comet aggregate native aggregation expression #283

Closed
viirya opened this issue Apr 18, 2024 · 0 comments · Fixed by #284
Assignees
Labels
bug Something isn't working

Comments

@viirya
Copy link
Member

viirya commented Apr 18, 2024

Describe the bug

Another one bug found while fixing test failures in #250.

Aggregate expression with filer is incorrectly translated to Comet aggregate native aggregation expression without filter now. It causes at least one query failure.

For example, in org.apache.spark.sql.SQLQueryTestSuite:

[info] - count.sql *** FAILED *** (3 seconds, 483 milliseconds)
[info]   count.sql
[info]   Expected "[1	1]", but got "[2	2]" Result did not match for query #7
[info]   SELECT count(DISTINCT 2), count(DISTINCT 3,2) (SQLQueryTestSuite.scala:495)

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

@viirya viirya added the bug Something isn't working label Apr 18, 2024
@viirya viirya self-assigned this Apr 18, 2024
@viirya viirya changed the title Aggregate expression with filer is incorrectly translated to Comet aggregate native aggregation expression Aggregate expression with filter is incorrectly translated to Comet aggregate native aggregation expression Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant