Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scalar function in DataFusion cannot coerce dictionary type inputs #265

Closed
viirya opened this issue Apr 14, 2024 · 3 comments
Closed

Scalar function in DataFusion cannot coerce dictionary type inputs #265

viirya opened this issue Apr 14, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@viirya
Copy link
Member

viirya commented Apr 14, 2024

Describe the bug

This is found during debugging #250.

The current input type coercion rule of scalar functions in DataFusion cannot handle Dictionary types. In TPCDS queries, The PR #250 encounters an error on Coalesce function with q8:

Error during planning: Coercion from [Dictionary(Int32, Utf8), Utf8] to the signature VariadicEqual failed

This has to be fixed at DataFusion instead of Comet.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response
@viirya viirya added the bug Something isn't working label Apr 14, 2024
@viirya
Copy link
Member Author

viirya commented Apr 14, 2024

I will go to submit a fix to DataFusion.

@viirya viirya mentioned this issue Apr 14, 2024
Closed
@viirya
Copy link
Member Author

viirya commented Apr 15, 2024

This is fixed at DataFusion. I will update the diffs into the forked DataFusion branch.

@viirya
Copy link
Member Author

viirya commented Apr 18, 2024

The diff is updated.

@viirya viirya closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@viirya