From 5faf16762b3285c124885e10f0ca2647e578e2ef Mon Sep 17 00:00:00 2001
From: Andy Grove <agrove@apache.org>
Date: Fri, 5 Jul 2024 13:48:33 -0600
Subject: [PATCH] ignore some tests when miri is enabled

---
 core/src/errors.rs                          | 9 +++++++++
 core/src/execution/datafusion/spark_hash.rs | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/core/src/errors.rs b/core/src/errors.rs
index b6f4d0889..352f934ef 100644
--- a/core/src/errors.rs
+++ b/core/src/errors.rs
@@ -586,6 +586,7 @@ mod tests {
     }
 
     #[test]
+    #[cfg_attr(miri, ignore)]
     pub fn error_from_panic() {
         let _guard = attach_current_thread();
         let mut env = jvm().get_env().unwrap();
@@ -604,6 +605,7 @@ mod tests {
     // Verify that functions that return an object are handled correctly.  This is basically
     // a test of the "happy path".
     #[test]
+    #[cfg_attr(miri, ignore)]
     pub fn object_result() {
         let _guard = attach_current_thread();
         let mut env = jvm().get_env().unwrap();
@@ -621,6 +623,7 @@ mod tests {
     // Verify that functions that return an native time are handled correctly.  This is basically
     // a test of the "happy path".
     #[test]
+    #[cfg_attr(miri, ignore)]
     pub fn jlong_result() {
         let _guard = attach_current_thread();
         let mut env = jvm().get_env().unwrap();
@@ -637,6 +640,7 @@ mod tests {
     // Verify that functions that return an array can handle throwing exceptions.  The test
     // causes an exception by dividing by zero.
     #[test]
+    #[cfg_attr(miri, ignore)]
     pub fn jlong_panic_exception() {
         let _guard = attach_current_thread();
         let mut env = jvm().get_env().unwrap();
@@ -657,6 +661,7 @@ mod tests {
     // Verify that functions that return an native time are handled correctly.  This is basically
     // a test of the "happy path".
     #[test]
+    #[cfg_attr(miri, ignore)]
     pub fn jlong_result_ok() {
         let _guard = attach_current_thread();
         let mut env = jvm().get_env().unwrap();
@@ -673,6 +678,7 @@ mod tests {
     // Verify that functions that return an native time are handled correctly.  This is basically
     // a test of the "happy path".
     #[test]
+    #[cfg_attr(miri, ignore)]
     pub fn jlong_result_err() {
         let _guard = attach_current_thread();
         let mut env = jvm().get_env().unwrap();
@@ -693,6 +699,7 @@ mod tests {
     // Verify that functions that return an array are handled correctly.  This is basically
     // a test of the "happy path".
     #[test]
+    #[cfg_attr(miri, ignore)]
     pub fn jint_array_result() {
         let _guard = attach_current_thread();
         let mut env = jvm().get_env().unwrap();
@@ -713,6 +720,7 @@ mod tests {
     // Verify that functions that return an array can handle throwing exceptions.  The test
     // causes an exception by dividing by zero.
     #[test]
+    #[cfg_attr(miri, ignore)]
     pub fn jint_array_panic_exception() {
         let _guard = attach_current_thread();
         let mut env = jvm().get_env().unwrap();
@@ -736,6 +744,7 @@ mod tests {
     /// See [`object_panic_exception`] for a test which involves generating a panic and verifying
     /// that the resulting stack trace includes the offending call.
     #[test]
+    #[cfg_attr(miri, ignore)]
     pub fn stacktrace_string() {
         // Setup: Start with a backtrace that includes all of the expected scenarios, including
         // cases where the file and location are not provided as part of the backtrace capture
diff --git a/core/src/execution/datafusion/spark_hash.rs b/core/src/execution/datafusion/spark_hash.rs
index 1f0658aec..dea5b0f50 100644
--- a/core/src/execution/datafusion/spark_hash.rs
+++ b/core/src/execution/datafusion/spark_hash.rs
@@ -90,7 +90,7 @@ pub(crate) fn spark_compatible_murmur3_hash<T: AsRef<[u8]>>(data: T, seed: u32)
     unsafe {
         let mut h1 = if len_aligned > 0 {
             hash_bytes_by_int(
-                std::slice::from_raw_parts(data.get_unchecked(0), len_aligned),
+                &data[0..len_aligned],
                 seed,
             )
         } else {