CXF-8700: Eliminate the java.compiler dependency from cxf-core
#946
Conversation
rotty3000
force-pushed
the
thin.cxf.core
branch
2 times, most recently
from
b0f28d8
to
14ff3fd
Compare
rotty3000
force-pushed
the
thin.cxf.core
branch
2 times, most recently
from
5656335
to
f62cbd4
Compare
|
enabling Karaf debug settings in |
@rotty3000 could you please uncomment |
|
@reta done! |
Could see a few things: system.properties: /home/jenkins/workspace/CXF/CXF-JDK11-PR/.repository has Looking why PAX does not seem to pick the artifacts. |
...ests/sts-itests/src/test/java/org/apache/cxf/systest/sts/itests/BasicSTSIntegrationTest.java
Outdated
Show resolved
Hide resolved
...ests/sts-itests/src/test/java/org/apache/cxf/systest/sts/itests/BasicSTSIntegrationTest.java
Outdated
Show resolved
Hide resolved
|
Oh, I see all checks have now passed :) |
Signed-off-by: Raymond Augé <[email protected]>
…er to lower footprint of `java.desktop` dependency Signed-off-by: Raymond Augé <[email protected]>
…esent, reduces the footprint of the `java.desktop` dependency Signed-off-by: Raymond Augé <[email protected]>
…a.desktop` dependency Signed-off-by: Raymond Augé <[email protected]>
…dependency on `java.desktop` Signed-off-by: Raymond Augé <[email protected]>
…ere it's used, reduce footprint of `java.desktop` dependency Signed-off-by: Raymond Augé <[email protected]>
|
Thanks for the pull request @rotty3000! My apologies for the delay looking into it. May I ask you please to split this request into smaller ones. It seems like you have bundled |
| @@ -17,7 +17,7 @@ | |||
| * under the License. | |||
| */ | |||
|
|
|||
| package org.apache.cxf.common.util; | |||
There was a problem hiding this comment.
Could we please keep the same package? I understand that we would have package split brain but this is public API and if we want this change into 3.4.x / 3.5.x / 3.6.x, we should not break the possible consumers.
Alternatively, we could keep package change BUT introduce org.apache.cxf.common.util.Compiler class which will delegate to org.apache.cxf.tools.compiler.Compiler: it seems like public API is not using any dependencies from java.compiler APIs.
| @@ -414,6 +414,11 @@ | |||
| <artifactId>cxf-tools-common</artifactId> | |||
| <version>${project.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
I believe we should add this dependency to cxf-core (which could be excluded on demand) to not break existing applications if anyone is using Compiler class (since this is public API).
Signed-off-by: Raymond Augé [email protected]