VAT Id Number validators for all EU countries #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check Digit calculation/validation https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-494
Error: Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.24.0:check (default-cli) on project commons-validator: PMD 7.4.0 has found 1 violation. For more details see: /home/runner/work/commons-validator/commons-validator/target/pmd.xml -> [Help 1]
This reverts commit 62c5f75.
minor changes in VATidATCheckDigit
Check Digit calculation/validation It is a subclass from Modulus97CheckDigit, which is also used to validate the LEI and German Leitweg, see apache#61 This implemets parts of https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-494
Check Digit calculation/validation https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-494
- add testcases with branches
Move new style 9755 test codes to VATINValidatorTest
updated the |
array if checkDigitLth is 0. This applays to VATIN in DK and SK.
…n empty" This reverts commit 18741c6.
Method AbstractCheckDigitTest.createInvalidCodes should return empty array if checkDigitLth is 0. This applays to VATIN in DK and SK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @garydgregory ,
here is EUgen from Europe.
With this PR I provide validation and check digit calculation for VAT Id Numbers VATIN for all countries in the EU. This number is neccessary in the intra comunity trades to apply a zero VAT rate.
You can find a documentation of the different VATINs structures in my VATIN wiki (de)
The validator for all is
VATINValidator- it implements the jira issue 494Pls review and merge.
Regards EUGen