-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CELEBORN-1700] Flink supports fallback to vanilla Flink built-in shuffle implementation #2932
Conversation
bb83198
to
85d5429
Compare
85d5429
to
6321ad8
Compare
Ping @reswqa, @codenohup, @RexXiong. |
.../common/src/main/java/org/apache/celeborn/plugin/flink/AbstractRemoteShuffleEnvironment.java
Show resolved
Hide resolved
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/celeborn/plugin/flink/fallback/WorkersAvailableFallbackPolicy.java
Show resolved
Hide resolved
1f57391
to
dfc93da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution!
dfc93da
to
6f68761
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except a minor
tests/flink-it/src/test/scala/org/apache/celeborn/tests/flink/WordCountTest.scala
Show resolved
Hide resolved
…ffle implementation
…ffle implementation
6f68761
to
e4dbe45
Compare
…ffle implementation
e4dbe45
to
83e9555
Compare
Thanks, merge to main(v0.6.0) |
What changes were proposed in this pull request?
Flink supports fallback to vanilla Flink built-in shuffle implementation.
Why are the changes needed?
When quota is unenough or workers are unavailable,
RemoteShuffleMaster
does not support fallback toNettyShuffleMaster
, andRemoteShuffleEnvironment
does not support fallback toNettyShuffleEnvironment
at present. Flink should support fallback to vanilla Flink built-in shuffle implementation for unenough quota and unavailable workers.Does this PR introduce any user-facing change?
ShuffleFallbackPolicy
interface to determine whether fallback to vanilla Flink built-in shuffle implementation.celeborn.client.flink.shuffle.fallback.policy
config to support shuffle fallback policy configuration.How was this patch tested?
RemoteShuffleMasterSuiteJ#testRegisterJobWithForceFallbackPolicy
WordCountTestBase#celeborn flink integration test with fallback - word count