Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some metrics for CoGBK profiling. #30979

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Add some metrics for CoGBK profiling. #30979

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f92a63
Add some metrics for CoGBK optimization.
robertwb Apr 15, 2024
91fe0c3
cleanup
robertwb Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGbkResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
import org.apache.beam.sdk.coders.CoderException;
import org.apache.beam.sdk.coders.CustomCoder;
import org.apache.beam.sdk.coders.IterableCoder;
import org.apache.beam.sdk.metrics.Counter;
import org.apache.beam.sdk.metrics.Metrics;
import org.apache.beam.sdk.util.common.Reiterator;
import org.apache.beam.sdk.values.PCollection;
import org.apache.beam.sdk.values.TupleTag;
Expand Down Expand Up @@ -73,6 +75,10 @@ public class CoGbkResult {

private static final Logger LOG = LoggerFactory.getLogger(CoGbkResult.class);

private Counter keyCount = Metrics.counter(CoGbkResult.class, "cogbk-keys");

private Counter largeKeyCount = Metrics.counter(CoGbkResult.class, "cogbk-large-keys");

/**
* A row in the {@link PCollection} resulting from a {@link CoGroupByKey} transform. Currently,
* this row must fit into memory.
Expand All @@ -91,6 +97,7 @@ public CoGbkResult(
int inMemoryElementCount,
int minElementsPerTag) {
this.schema = schema;
keyCount.inc();
List<List<Object>> valuesByTag = new ArrayList<>();
for (int unionTag = 0; unionTag < schema.size(); unionTag++) {
valuesByTag.add(new ArrayList<>());
Expand All @@ -103,6 +110,7 @@ public CoGbkResult(
while (taggedIter.hasNext()) {
if (elementCount++ >= inMemoryElementCount) {
// Let the tails be lazy.
largeKeyCount.inc();
break;
}
RawUnionValue value = taggedIter.next();
Expand Down Expand Up @@ -636,6 +644,10 @@ void offer(ObservingReiterator<RawUnionValue> tail) {
}

void finish() {
Metrics.counter(
CoGbkResult.class,
this.tail == null ? "cogbk-small-iterables" : "cogbk-large-iterables")
.inc();
finished = true;
}

Expand Down Expand Up @@ -838,8 +850,11 @@ protected Object computeNext() {
// We got to the end of the iterable, update the shared set of values with those sets that
// were small enough to cache.
if (!sharedSeenEnd[0]) {
Counter smallIterablesCount = Metrics.counter(CoGbkResult.class, "cogbk-small-iterables");
Counter largeIterablesCount = Metrics.counter(CoGbkResult.class, "cogbk-large-iterables");
for (int i = 0; i < sharedValueMap.size(); i++) {
List<Object> localValues = localValueMap.get(i);
(localValues == null ? largeIterablesCount : smallIterablesCount).inc();
sharedValueMap.set(
i, localValues != null ? localValues : simpleFilteringIterable(taggedIterable, i));
}
Expand Down
Loading