Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] Catch EOFError along with StopIteration (#28896) #28901

Closed
wants to merge 1 commit into from
Closed

[cherry-pick] Catch EOFError along with StopIteration (#28896) #28901

wants to merge 1 commit into from

Conversation

riteshghorse
Copy link
Contributor

Fixes the fastavro regression with 1.8.4 release causing failures for Python PostCommits

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@riteshghorse
Catch EOFError along with StopIteration (apache#28896)
e815ad2 
* catch EOF instead of StopIteration

* add stop iteration to close

* catch both stop iteration and EOF
@riteshghorse
Copy link
Contributor Author

Run Python 3.8 PostCommit

@riteshghorse
Copy link
Contributor Author

R: @kennknowles

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #28901 (e815ad2) into release-2.51.0 (e600ea8) will decrease coverage by 0.04%.
Report is 2 commits behind head on release-2.51.0.
The diff coverage is 0.00%.

@@                Coverage Diff                 @@
##           release-2.51.0   #28901      +/-   ##
==================================================
- Coverage           72.25%   72.21%   -0.04%     
==================================================
  Files                 684      684              
  Lines              101070   101070              
==================================================
- Hits                73024    72992      -32     
- Misses              26467    26499      +32     
  Partials             1579     1579
Flag Coverage Δ
python 82.79% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery.py 69.92% <0.00%> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

kennknowles
kennknowles approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go add tests!

@kennknowles
Copy link
Member

This is caught only in postcommit, right? There is no additional unit test added for this. It should have unit tests to catch it earlier.

@riteshghorse
Copy link
Contributor Author

This is caught only in postcommit, right? There is no additional unit test added for this. It should have unit tests to catch it earlier.

yes. I checked bigquery_test.py and there are no tests for DIRECT_READ method. Tagging folks familiar with bigquery IO @ahmedabu98 @Abacn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@kennknowles
Copy link
Member

ModuleNotFoundError: No module named 'tensorflow'

@riteshghorse
Copy link
Contributor Author

CC: @jrmccluskey

@jrmccluskey
Copy link
Contributor

In the Python PostCommit? That should have gotten fixed... @tvalentyn ? Stems from removing tensorflow from base python containers

@riteshghorse
Copy link
Contributor Author

riteshghorse commented Oct 10, 2023 •
edited
Loading

Closing this PR in favor of adding a note to known issues of upgrading fastavro to 1.8.4.

Anyway, the tensorflow module not found error is coming out of example file involved in a test. There is one more vertex_ai test that runs fine. So I don't think there is a problem with the model handler itself and we can ignore that failing test to unblock from releasing and handle on master branch. WDYT @jrmccluskey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennknowles kennknowles kennknowles approved these changes

Assignees
No one assigned
Labels
Next Action: Reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riteshghorse @kennknowles @jrmccluskey