Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka add gauge v1 #33408

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Naireen
Copy link
Contributor

@Naireen Naireen commented Dec 17, 2024

Add per worker gauge support to add per backlog partition for kafka with java legacy worker for Dataflow

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.95%. Comparing base (8da9bbe) to head (b7b7e2a).
Report is 190 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #33408      +/-   ##
============================================
+ Coverage     58.86%   58.95%   +0.08%     
- Complexity     3112     3183      +71     
============================================
  Files          1130     1133       +3     
  Lines        174419   174576     +157     
  Branches       3343     3366      +23     
============================================
+ Hits         102680   102916     +236     
+ Misses        68392    68312      -80     
- Partials       3347     3348       +1     
Flag Coverage Δ
java 70.33% <ø> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Naireen Naireen force-pushed the kafka_add_counters_V1 branch 4 times, most recently from 2791b23 to b91a77f Compare December 18, 2024 01:21
@Naireen Naireen marked this pull request as ready for review December 18, 2024 04:18
@Naireen
Copy link
Contributor Author

Naireen commented Dec 18, 2024

R: @sjvanrossum for the kafka io part, thanks in advance!

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Naireen Naireen force-pushed the kafka_add_counters_V1 branch from b91a77f to 948dfe6 Compare December 18, 2024 07:34
@Naireen
Copy link
Contributor Author

Naireen commented Dec 18, 2024

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Dec 18, 2024

R: @johnjcasey for the sdk portion of it.

@Naireen
Copy link
Contributor Author

Naireen commented Dec 19, 2024

Run Java_Pulsar_IO_Direct PreCommit

@Naireen Naireen force-pushed the kafka_add_counters_V1 branch from 11bee27 to b9d2f2b Compare December 19, 2024 19:54
@Naireen
Copy link
Contributor Author

Naireen commented Dec 19, 2024

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Dec 19, 2024

Run Java_GCP_IO_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Dec 19, 2024

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Dec 19, 2024

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Dec 19, 2024

Run Java_GCP_IO_Direct PreCommit

1 similar comment
@Naireen
Copy link
Contributor Author

Naireen commented Dec 19, 2024

Run Java_GCP_IO_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Dec 19, 2024

Run Java PreCommit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants