Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FnHarness and FinalizeBundleHandler to use ScheduledExecutorService instead of ExecutorService. #33247

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjvanrossum
Copy link
Contributor

FinalizeBundleHandler schedules tasks immediately onto the shared (Scheduled)ExecutorService. When the task runs it immediately blocks the thread until the earliest delay has expired. Doing so prevents the shared execution thread from being reused and may force the creation of new tasks which are truly able to execute immediately.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Nov 28, 2024
@sjvanrossum sjvanrossum marked this pull request as draft November 28, 2024 14:21
@sjvanrossum
Copy link
Contributor Author

Converting to draft, misread the implementation of FinalizeBundleHandler which only retains a single thread to perform its tasks. This change would have every finalize task co-schedule onto the execution thread pool. Depending on the perf impact of scheduling on the same pool, this PR can be amended to have FinalizeBundleHandler use a dedicated single threaded ScheduledExecutorService which should be equivalent to the current implementation that only differs in the amount of lines to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant