Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate circular reference for yaml #33208

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Conversation

mravi
Copy link
Contributor

@mravi mravi commented Nov 25, 2024

Addresses #32339

The code raises a ValueError for transforms that self references it's input.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Reminder, please take a look at this pr: @liferoad

@liferoad
Copy link
Collaborator

liferoad commented Dec 2, 2024

R: @Polber

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

sdks/python/apache_beam/yaml/yaml_transform.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/yaml/yaml_transform.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/yaml/yaml_transform.py Outdated Show resolved Hide resolved
@mravi
Copy link
Contributor Author

mravi commented Dec 10, 2024

ptal @robertwb . Additionally, the failure seem unrelated to my changes ! I tested the failing test locally and it works! Do you recommend a dummy commit to re-trigger an entire build or is there a git command like /rebuild that can re-trigger the build .

@mravi mravi force-pushed the rm_yaml_validation branch from 1199e5b to a3e87b6 Compare December 14, 2024 23:09
@robertwb robertwb merged commit e68a79c into apache:master Dec 18, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants