Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gcp bom to 26.50.0 #33192

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Update gcp bom to 26.50.0 #33192

wants to merge 5 commits into from

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Nov 22, 2024

This notably includes upgrading protobuf. Changes are segmented by commit:

  • Update the bom with the bom updater script - e8b2c0a
  • Remove null checks - 5762104 - this is because proto fields can no longer be null (they'll at least have a default implementation)
  • Update google_cloud_bigdataoss_version - 4a5efdd - this is because gcsio was not compatible with Protobuf 4 until this release.
  • Update aws client versions to be compatible with Protobuf 4 - b72d791

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm damccorm marked this pull request as draft November 22, 2024 18:08
@damccorm
Copy link
Contributor Author

Some failures are caused because proto fields can no longer be null (they'll at least have a default implementation). Addressing this now

@github-actions github-actions bot added the aws label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant