-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Enrichment Handlers to PEP 585 typing #33087
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@jrmccluskey , I meet a issue want to reference BigQueryEnrichementHandler to generate a SpannerEnrichemenetHandler. Could you please help check how can batch list data can be received in def call(self, request: Union[beam.Row, list[beam.Row]], *args, **kwargs): method in SpannerEnrichemenetHandler() Create pipline as below approach spanner_handler = SpannerMultiLineEnrichmentHandler(
|
I just want to get batch beam.raw list one time instead of one by one, please help on it, thanks. |
Hey @lianliangzhang in general it is probably better to create a GitHub issue to discuss questions like this - could you please open one here and tag me, @jrmccluskey , and @claudevdm ? Please include the code you are currently using to define |
Updates type hints to PEP 585 standards.
Part of #32969
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.