Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Enrichment Handlers to PEP 585 typing #33087

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

jrmccluskey
Copy link
Contributor

Updates type hints to PEP 585 standards.

Part of #32969


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jrmccluskey jrmccluskey merged commit 941e542 into apache:master Nov 12, 2024
91 checks passed
@lianliangzhang
Copy link

@jrmccluskey , I meet a issue want to reference BigQueryEnrichementHandler to generate a SpannerEnrichemenetHandler.

Could you please help check how can batch list data can be received in def call(self, request: Union[beam.Row, list[beam.Row]], *args, **kwargs): method in SpannerEnrichemenetHandler()
I want to use EnrichemenetHandler to handle batch element instead of one by one beam. raw element, but when I put input data as below list, the data still comes to handler one by one. requests = [
beam.Row(sale_id=1, Consumer_Id='0b47c98f-58bf-4ae6-8577-9257f14ee7e6', product_id=1, quantity=1),
beam.Row(sale_id=3, Consumer_Id='e687e75a-d4be-411b-9301-4777183b2611', product_id=2, quantity=3),
beam.Row(sale_id=5, Consumer_Id='5c17e957-ceea-4ab9-a9d9-2d9f84c91380', product_id=4, quantity=2)
]

Create pipline as below approach

spanner_handler = SpannerMultiLineEnrichmentHandler(
project=project_id,
instance_id=instance_id,
database=database,
row_restriction_template=row_key + " ='{}'",
table_name=table_id,
fields=fields,
min_batch_size=3,
max_batch_size=3)

with beam.Pipeline() as p:
    _ = (
            p
            | "Create" >> beam.Create(requests)
            | "Enrich W/ Spanner" >> Enrichment(spanner_handler)
            | "Print" >> beam.Map(print))

@lianliangzhang
Copy link

I just want to get batch beam.raw list one time instead of one by one, please help on it, thanks.

@damccorm
Copy link
Contributor

Hey @lianliangzhang in general it is probably better to create a GitHub issue to discuss questions like this - could you please open one here and tag me, @jrmccluskey , and @claudevdm ? Please include the code you are currently using to define SpannerMultiLineEnrichmentHandler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants